-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ToString and comparison operators to ByteRate with tests #803
base: main
Are you sure you want to change the base?
Conversation
Looks like my typo correction has caused one of the tests to fail. I'll revert that change. |
Failing on the approve_public_api test, since that's what I've changed.
Now
Could do with some feedback or guidance on best way to proceed here. |
If you run either build.cmd or build.ps1 it should come up with a method of updating the PublicApiApprovalTest.approve_public_api.approved.txt file. Once that matches the public api, the test will then pass |
Hi Claire, would you be willing to have another look at this, I've hopefully resolved any remaining concerns. |
Looks like there's a build error that needs to be resolved? |
You're right, I jumped the gun. Looks like some issues in Master |
Now passing tests |
@Cirzen sorry for the delay. can you rebase and re-approve the api changes |
Fixes #802
Here is a checklist you should tick through before submitting a pull request:
dev
branch (more info below)fixes #<the issue number>
build.cmd
orbuild.ps1
and ensure there are no test failures